Use the New MatrixRTCSession MembershipManager #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
force-pushed
the
toger5/test-with-new-membershipmanager
branch
from
7fc4a5e to
05e6582
Compare
toger5
force-pushed
the
toger5/test-with-new-membershipmanager
branch
from
e2bbe5b to
7fe87a3
Compare
toger5
force-pushed
the
toger5/test-with-new-membershipmanager
branch
from
7fe87a3 to
3993cf3
Compare
toger5
force-pushed
the
toger5/test-with-new-membershipmanager
branch
from
3993cf3 to
72fe81c
Compare
toger5
force-pushed
the
toger5/test-with-new-membershipmanager
branch
from
72fe81c to
dfd8aa6
Compare
toger5
force-pushed
the
toger5/test-with-new-membershipmanager
branch
from
ac4ae70 to
aeaa066
Compare
toger5
changed the title
toger5
force-pushed
the
toger5/test-with-new-membershipmanager
branch
from
2986aab to
af06c1b
Compare
toger5
force-pushed
the
toger5/test-with-new-membershipmanager
branch
from
28c3619 to
1ab150c
Compare
toger5
force-pushed
the
toger5/test-with-new-membershipmanager
branch
2 times, most recently
from
800952e to
bb9d6b5
Compare
toger5
force-pushed
the
toger5/test-with-new-membershipmanager
branch
from
bb9d6b5 to
c695ff4
Compare
…t will be handled by an effect.
hughns
changed the title
…cated `rtcSession.room`)
hughns
reviewed
Feb 28, 2025
hughns
reviewed
Feb 28, 2025
Co-authored-by: Hugh Nimmo-Smith <[email protected]>
Co-authored-by: Hugh Nimmo-Smith <[email protected]>
hughns
requested changes
Feb 28, 2025
| type MatrixClient, | ||
| type MatrixEvent, | ||
| } from "matrix-js-sdk/src/matrix"; | ||
| import { type CryptoApi } from "matrix-js-sdk/src/crypto-api"; |
There was a problem hiding this comment.
I'm nor sure why these are in this PR? 🤷
There was a problem hiding this comment.
Because we updated the js-sdk. And they recently deprecated non rust crypto and did some breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3032
The is a developer mode option to switch back to the old/LegacyMembershipManager.