Reject sha1 hash algo

emersion · Mar 11, 2019 · 1f1b0f7 · 1f1b0f7
1 parent 1eaa896
commit 1f1b0f7
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/verify.go b/verify.go
@@ -6,6 +6,7 @@ import (
 	"crypto"
 	"crypto/subtle"
 	"encoding/base64"
+	"fmt"
 	"io"
 	"io/ioutil"
 	"regexp"
@@ -243,7 +244,9 @@ func verify(h header, r io.Reader, sigField, sigValue string) (*Verification, er
 	var hash crypto.Hash
 	switch hashAlgo {
 	case "sha1":
-		hash = crypto.SHA1
+		// RFC 8301 section 3.1: rsa-sha1 MUST NOT be used for signing or
+		// verifying.
+		return verif, permFailError(fmt.Sprintf("hash algorithm too weak: %v", hashAlgo))
 	case "sha256":
 		hash = crypto.SHA256
 	default: