Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting lookup DNS/TXT function #25

Closed
wants to merge 5 commits into from
Closed

Allow setting lookup DNS/TXT function #25

wants to merge 5 commits into from

Conversation

huicao
Copy link
Contributor

@huicao huicao commented Apr 11, 2020

This change can allow us cache the record to minimize latency

Hui Cao added 5 commits November 15, 2019 11:49
Change-Id: I0e023a602004bb18f573321c5811d1c876312663
Change-Id: Id23c3a5f168214f441268e582d6448ab57defa12
Change-Id: I299ac0c11aac1dda96c6637e2590413518972a1e
Change-Id: I19519a0a10289aa770156ca4ebfc8ce3b20c4a35
Change-Id: I5f77d2c52ace909fb18696492b9c4c6ce3ed5e57
@codecov-io
Copy link

Codecov Report

Merging #25 into master will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   66.50%   66.34%   -0.17%     
==========================================
  Files           7        7              
  Lines         827      829       +2     
==========================================
  Hits          550      550              
- Misses        208      210       +2     
  Partials       69       69              
Impacted Files Coverage Δ
dkim/query.go 29.16% <0.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74fc936...89e8201. Read the comment docs.

@foxcpp
Copy link
Contributor

foxcpp commented Apr 11, 2020

Ref. #4 #10

Copy link
Contributor

@foxcpp foxcpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global variable seems to be a quick hack. I think having a VeriifyOptions structure similar to SignOptions is more useful and clean.

@huicao
Copy link
Contributor Author

huicao commented Apr 12, 2020

I agree. Would you mind to bring up your patch again? I think this is very useful.

@huicao huicao closed this Apr 12, 2020
@foxcpp foxcpp mentioned this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants