Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dkim: optimize relaxedBodyCanonicalizer allocations #47

Merged
merged 1 commit into from
Mar 30, 2021
Merged

dkim: optimize relaxedBodyCanonicalizer allocations #47

merged 1 commit into from
Mar 30, 2021

Conversation

pierrre
Copy link
Contributor

@pierrre pierrre commented Mar 30, 2021

  • reslice crlfBuf to an empty slice, instead of reset it to nil
  • change wspBuf to a boolean, the content was not used

Fixes #46

@pierrre
dkim: optimize relaxedBodyCanonicalizer allocations
e6d0592 
- reslice crlfBuf to an empty slice, instead of reset it to nil
- change wspBuf to a boolean, the content was not used

Fixes #46
@pierrre pierrre mentioned this pull request Mar 30, 2021
Closed
emersion
emersion approved these changes Mar 30, 2021
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@emersion emersion merged commit e98a2ee into emersion:master Mar 30, 2021
@pierrre pierrre deleted the optimize-relaxedBodyCanonicalizer-alloc branch March 30, 2021 07:42
@pierrre
Copy link
Contributor Author

pierrre commented Mar 30, 2021

Do you plan to do a tagged version soon ?
I want to test it in my app, and a tag is easier to use.
I can use the commit ID in the go.mod in the mean time.

@emersion
Copy link
Owner

Released v0.6.5: https://github.com/emersion/go-msgauth/releases/tag/v0.6.5

@pierrre
Copy link
Contributor Author

pierrre commented Mar 30, 2021

thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reduce relaxedBodyCanonicalizer allocations
2 participants
@pierrre @emersion