Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to hook into the HELO commands #136

Closed
Savageman opened this issue Jan 29, 2021 · 3 comments · Fixed by #146
Closed

Add a way to hook into the HELO commands #136

Savageman opened this issue Jan 29, 2021 · 3 comments · Fixed by #146
Labels
enhancement

Comments

@Savageman
Copy link

Similar to #130, a hook to the HELO commands can be useful to implement security depending on the value of the argument provided.

Examples: check the domain syntax, its existence, whether it's correctly configured to accept emails, etc.
@foxcpp
Copy link
Collaborator

foxcpp commented Jan 30, 2021 •
edited
Loading

Possibly relevant: #114 (comment) #114 (comment)

Perhaps it is a time for the third backend interface revision?)

@emersion
Copy link
Owner

Indeed. Seems like it would make sense to just do what your comment says.

foxcpp added a commit to foxcpp/go-smtp that referenced this issue Jul 16, 2021
@foxcpp
server: Remove authentication-related session creation
ec3cfb6 
Closes emersion#136.
Closes emersion#130.
@foxcpp foxcpp mentioned this issue Jul 16, 2021
Merged
foxcpp added a commit to foxcpp/go-smtp that referenced this issue Jul 20, 2021
@foxcpp
server: Remove authentication-related session creation
57e151c 
Closes emersion#136.
Closes emersion#130.
foxcpp added a commit to foxcpp/go-smtp that referenced this issue Jul 20, 2021
@foxcpp
server: Remove authentication-related session creation
03f1388 
Closes emersion#136.
Closes emersion#130.
emersion pushed a commit that referenced this issue Jul 20, 2021
@foxcpp @emersion
server: Remove authentication-related session creation
ff30d70 
Closes #136.
Closes #130.
@foxcpp
Copy link
Collaborator

foxcpp commented Jul 20, 2021

With the recent backend interface change, NewSession runs on HELO/EHLO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: Remove authentication-related session creation foxcpp/go-smtp
3 participants
@Savageman @emersion @foxcpp