Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Impossible to disable PLAIN auth #170

Closed
kayrus opened this issue Nov 29, 2021 · 2 comments · Fixed by #251
Closed

server: Impossible to disable PLAIN auth #170

kayrus opened this issue Nov 29, 2021 · 2 comments · Fixed by #251

Comments

@kayrus
Copy link
Contributor

kayrus commented Nov 29, 2021

PLAIN auth is enabled by default and it is not possible to disable it:

go-smtp/server.go

Lines 86 to 87 in 30169ac

auths: map[string]SaslServerFactory{
sasl.Plain: func(conn *Conn) sasl.Server {

it also doesn't look correct that Session interface now requires the AuthPlain method (#146). Why doesn't it require other auth methods? Why don't rely on sasl auth methods defined explicitly?

@emersion
Copy link
Owner

emersion commented Nov 9, 2023

@emersion emersion changed the title auth: Impossible to disable PLAIN auth server: Impossible to disable PLAIN auth Feb 13, 2024
emersion added a commit that referenced this issue Feb 21, 2024
@emersion
Copy link
Owner

#254 fixes this.

emersion added a commit that referenced this issue Mar 28, 2024
emersion added a commit that referenced this issue Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants