Improved error handling in Server.Serve #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now Serve does not exit on non-fatal errors from Accept. This resolves emersion#180 It also logs handleConn errors to the ErrorLog - which is a partial improvement for emersion#167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, not sure if you'd like the test implementation (that mock listener might be a bit weird - if you feel so, would appreciate any suggestions on how it can be improved) but here is what I came up with to address #180.
Now
Servedoes not exit on non-fatal errors fromAccept. It also logshandleConnerrors to theErrorLog- which is not a solution but should be a partial improvement for #167.