Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken encodeXtext() #232

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix broken encodeXtext() #232

merged 1 commit into from
Sep 7, 2023

Conversation

ikedas
Copy link
Collaborator

@ikedas ikedas commented Aug 28, 2023 •
edited
Loading

With this method call:

email := "[email protected]"
c.Mail(email, &MailOptions{Auth: &email})

this should be sent to the server:

MAIL FROM:<[email protected]> [email protected]

However, following thing is sent:

MAIL FROM:<[email protected]> AUTH=e+65+3D=+3Dm+6Dc+632+32@+40e+65x+78a+61m+6Dp+70l+6Ce+65.+2Ec+63o+6Fm+6D

This PR will fix it.

@ikedas ikedas mentioned this pull request Sep 3, 2023
Closed
emersion
emersion reviewed Sep 7, 2023
View reviewed changes
@emersion
Copy link
Owner

emersion commented Sep 7, 2023

Overall LGTM, the old code was definitely broken.

emersion
emersion approved these changes Sep 7, 2023
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@emersion emersion merged commit 42a0048 into emersion:master Sep 7, 2023
@ikedas ikedas deleted the bug_encodeXtext branch September 7, 2023 03:33
@ikedas ikedas mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikedas @emersion