Make go vet happy with server example #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 63.43% 63.43%
=======================================
Files 7 7
Lines 670 670
=======================================
Hits 425 425
Misses 186 186
Partials 59 59Continue to review full report at Codecov.
|
emersion
reviewed
Jan 23, 2019
README.md
Outdated
| @@ -61,25 +61,29 @@ import ( | |||
| "io/ioutil" | |||
| "log" | |||
|
|
|||
| "github.com/emersion/go-smtp" | |||
| smtp "github.com/emersion/go-smtp" | |||
There was a problem hiding this comment.
Probalby not. This change was automatically made by the Go tools used by Visual Studio Code.
There was a problem hiding this comment.
Can you remove this change and rebase your PR?
|
Yes, I will undo this change.
|
|
Thanks! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes to
README.md:go vetasks for comments on exported methods when run against the server code from theREADME.md.