Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immediately pass envelope information to the backend #31

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Immediately pass envelope information to the backend #31

merged 1 commit into from
Mar 22, 2019

Conversation

foxcpp
Copy link
Collaborator

@foxcpp foxcpp commented Mar 22, 2019

Closes #22.

@foxcpp
server: Immediately pass envelope information to the backend
61c4e2a 
This allows backend to return an error on MAIL FROM or RCPT TO
(emersion#22).

backendutil.TransformBackend is removed for reasons explained here:
emersion#22 (comment)
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #31 into master will increase coverage by 0.44%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   63.67%   64.11%   +0.44%     
==========================================
  Files           7        6       -1     
  Lines         680      680              
==========================================
+ Hits          433      436       +3     
+ Misses        187      182       -5     
- Partials       60       62       +2
Impacted Files Coverage Δ
server.go 54.11% <100%> (ø) ⬆️
conn.go 64.37% <62.5%> (-2.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb207c...61c4e2a. Read the comment docs.

emersion
emersion approved these changes Mar 22, 2019
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emersion emersion merged commit 1a1363a into emersion:master Mar 22, 2019
@emersion
Copy link
Owner

Thanks!

@foxcpp foxcpp deleted the issue-22 branch March 22, 2019 21:23
@foxcpp foxcpp mentioned this pull request Mar 23, 2019
Closed
@foxcpp foxcpp mentioned this pull request Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foxcpp @emersion