Added Read and Write timeouts. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
- Coverage 64.11% 63.42% -0.7%
=========================================
Files 6 6
Lines 680 678 -2
=========================================
- Hits 436 430 -6
- Misses 182 184 +2
- Partials 62 64 +2
Continue to review full report at Codecov.
|
emersion
reviewed
Mar 31, 2019
go.sum
Outdated
| @@ -0,0 +1,2 @@ | |||
| github.com/emersion/go-sasl v0.0.0-20161116183048-7e096a0a6197 h1:rDJPbyliyym8ZL/Wt71kdolp6yaD4fLIQz638E6JEt0= | |||
There was a problem hiding this comment.
Can you remove this file? I should add it to .gitignore
emersion
reviewed
Mar 31, 2019
example_test.go
Outdated
| @@ -139,7 +139,8 @@ func ExampleNewServer() { | |||
|
|
|||
| s.Addr = ":1025" | |||
| s.Domain = "localhost" | |||
| s.MaxIdleSeconds = 300 | |||
| s.WriteTimeout = 300 | |||
There was a problem hiding this comment.
We should probably use saner values here. Something like 10 * time.Second.
emersion
reviewed
Mar 31, 2019
README.md
Outdated
| @@ -60,6 +60,7 @@ import ( | |||
| "io" | |||
| "io/ioutil" | |||
| "log" | |||
| "time" | |||
emersion
reviewed
Mar 31, 2019
example_test.go
Outdated
| @@ -11,6 +11,7 @@ import ( | |||
| "io/ioutil" | |||
| "log" | |||
| "strings" | |||
| "time" | |||
added 2 commits
March 31, 2019 18:14
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeouts for Read and Write.