Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c.nbrErrors checks #72

Closed
wants to merge 1 commit into from
Closed

Conversation

bengivre
Copy link

FIX: issue 71 - Denial of service possible (DoS)

go-smtp$ go test
PASS
ok  	github.com/emersion/go-smtp	0.014s

@codecov
Copy link

codecov bot commented Nov 16, 2019

Codecov Report

Merging #72 into master will decrease coverage by 0.54%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   63.81%   63.27%   -0.55%     
==========================================
  Files           8        8              
  Lines         818      825       +7     
==========================================
  Hits          522      522              
- Misses        217      224       +7     
  Partials       79       79
Impacted Files Coverage Δ
conn.go 59.94% <0%> (-0.71%) ⬇️
server.go 55.55% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc96f6...336ee7b. Read the comment docs.

@emersion
Copy link
Owner

Thanks for your PR! Can we extract this into a function, so that changing the message/code/limit/something else doesn't require patching three different locations?

@foxcpp
Copy link
Collaborator

foxcpp commented May 8, 2020

@BenoitGEORGELIN, any updates on this?

@nsmith5 nsmith5 mentioned this pull request Aug 11, 2020
@emersion
Copy link
Owner

Superseded by #116.

@emersion emersion closed this Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants