Shelltestrunner #787
Merged
Shelltestrunner #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
approved these changes
Apr 21, 2020
tsloughter
force-pushed
the
shelltestrunner
branch
2 times, most recently
from
6cbfe6d to
8bbf275
Compare
ferd
approved these changes
Apr 22, 2020
this test was supposed to be checking that the remote console was attached but the remsh was actually failing and the test "passed" because the node list would contain the node making the call to get the nodes list. It should have been checking for 2 not 1. But remote_console will fail always when run like this because it can't run in the background.
tsloughter
force-pushed
the
shelltestrunner
branch
from
8ce3605 to
4697806
Compare
ferd
approved these changes
Apr 26, 2020
tsloughter
force-pushed
the
shelltestrunner
branch
from
2252c1e to
9e24842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly opening this now to see if the github actions work.