split dist args into two separate variables #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps from duplicating dist args like epmd_module which is already in vm.args but was also being appended to commands like foreground that use vm.args. The EXTRA_DIST_ARGS are args that need to be added to every command while DIST_ARGS are ones that were taken from vm.args and thus only needed by commands not passing -args_file
ferd
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps from duplicating dist args like epmd_module which is
already in vm.args but was also being appended to commands like
foreground that use vm.args. The EXTRA_DIST_ARGS are args that
need to be added to every command while DIST_ARGS are ones that
were taken from vm.args and thus only needed by commands not
passing -args_file