Bug in fix #1148 #1237
Comments
|
You mean #1148 ? |
|
Yes |
|
Can you raise a PR to fix it then? If you have spotted the bug? |
|
It s detailed in my post. |
|
Yeah, I get it. But I'm asking you to raise PR if you have time :-) |
rpecheur
added a commit
to rpecheur/docker-maven-plugin-1
that referenced
this issue
Jul 2, 2019
…ocker config json file
|
Done #1238 |
rpecheur
added a commit
to rpecheur/docker-maven-plugin-1
that referenced
this issue
Jul 2, 2019
…ocker config json file
rhuss
pushed a commit
that referenced
this issue
Jul 22, 2019
|
#1238 is merged. Thanks for your patience and sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When data are extracted from local ~/.docker/config.json, "docker.buildArg" is not removed from property name.
It give:
"Build args set {docker.buildArg.http_proxy=http://127.0.0.1:3001}"
Instead of:
"Build args set {http_proxy=http://127.0.0.1:3001}"
In commit ad5b322:
BuildService.java: Line 217:
buildArgs.put(argPrefix + entry.getValue(), defaultProxyObj.get(entry.getKey()).getAsString());
-> Should remove argPrefix.
Thank you
The text was updated successfully, but these errors were encountered: