-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow a 'global' port properties file configuraiton option #90
Comments
If both are given, should the image specific property file override to the global one or should both be merged (and only a specific container port mapping overrides a global mapping) ? Maybe we can define a 'default' |
i based this on how the registry is handled where the more specific value takes precedence, so i think from a consistency standpoint we should stick w/ that. i'm also not sure i understand the other questions - i'm only proposing the global are you suggesting we offer a way to default values for various if yes, i like that idea a lot b/c i think |
Ok, understand. Its about writing out the port properties only (so, of course merigng is not needed here). Sorry, misunderstood my own plugin ;-). Think thats a good idea. I have still other things with higher prio, so if you like it, a PR is welcome (as always ;-) For the global |
right now the
portPropertyFile
needs to be specified on a perrun
basis for images which means i need to load/read multiple files instead of just one.as an enhancement, we should support defining a global
portPropertyFile
element for all images.the behavior will be similar to that of the registry configuration, if the image specifies the element it will take precedence over what is globally defined.
The text was updated successfully, but these errors were encountered: