Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow a 'global' port properties file configuraiton option #90

Closed
jgangemi opened this issue Feb 6, 2015 · 3 comments
Closed

allow a 'global' port properties file configuraiton option #90

jgangemi opened this issue Feb 6, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@jgangemi
Copy link
Collaborator

jgangemi commented Feb 6, 2015

right now the portPropertyFile needs to be specified on a per run basis for images which means i need to load/read multiple files instead of just one.

as an enhancement, we should support defining a global portPropertyFile element for all images.

the behavior will be similar to that of the registry configuration, if the image specifies the element it will take precedence over what is globally defined.

@jgangemi jgangemi self-assigned this Feb 6, 2015
@jgangemi jgangemi added this to the 0.12.0 milestone Feb 6, 2015
@jgangemi jgangemi changed the title allow a 'global' port properties file allow a 'global' port properties file configuraiton option Feb 6, 2015
@rhuss
Copy link
Collaborator

rhuss commented Feb 6, 2015

If both are given, should the image specific property file override to the global one or should both be merged (and only a specific container port mapping overrides a global mapping) ?

Maybe we can define a 'default' <run> configuration on the global level so that also for other properties defaults can be specified ?

@jgangemi
Copy link
Collaborator Author

jgangemi commented Feb 6, 2015

i based this on how the registry is handled where the more specific value takes precedence, so i think from a consistency standpoint we should stick w/ that.

i'm also not sure i understand the other questions - i'm only proposing the global portPropertyFile element here that will override the properties file that the dynamic port values get written to.

are you suggesting we offer a way to default values for various run options, such as defining a global 'wait' that will apply to all containers that could then be overwritten?

if yes, i like that idea a lot b/c i think env vars would be a perfect fit. if no, please explain. :)

@rhuss
Copy link
Collaborator

rhuss commented Jun 14, 2015

Ok, understand. Its about writing out the port properties only (so, of course merigng is not needed here). Sorry, misunderstood my own plugin ;-). Think thats a good idea. I have still other things with higher prio, so if you like it, a PR is welcome (as always ;-)

For the global <run> stuff it's probably a bit over the top (one has to explain it and debugging becomes harded), but a global <env> might be nice (but then again, for build, run or both ?)

@rhuss rhuss modified the milestones: 0.12.1, 0.12.0 Jun 14, 2015
@rhuss rhuss modified the milestones: 0.12.1, 0.13.1 Jul 3, 2015
@jgangemi jgangemi modified the milestones: 0.13.1, 0.13.3 Jul 18, 2015
leusonmario pushed a commit to leusonmario/docker-maven-plugin that referenced this issue Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants