Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: evaluate default value for Docker image tag when triggered by push on main. #146

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix: evaluate default value for Docker image tag when triggered by push on main. #146

merged 1 commit into from
Feb 13, 2025

Conversation

chenkins
Copy link
Contributor

@chenkins chenkins commented Feb 12, 2025 •
edited by Holzchopf
Loading

Changes

Related issues

Request for Comment

  • Risk:
  • Discussion:

for further notice: https://stackoverflow.com/questions/69177488/how-to-set-github-actions-as-required-status-checks

Checklist

  • Document changes in this pull request above.
  • Documentation is added in the docs folder for relevant behavior changes.
  • Technical guidelines listed in docs/CONTRIBUTING.md are followed.

@chenkins chenkins force-pushed the feature/fix-tag-when-run-on-push-to-main branch 2 times, most recently from 0b8bab1 to 3d32a31 Compare February 12, 2025 17:40
@chenkins chenkins marked this pull request as ready for review February 12, 2025 17:59
@chenkins chenkins requested a review from a team as a code owner February 12, 2025 17:59
Holzchopf
Holzchopf reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@Holzchopf Holzchopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good but I don't see how it's linked to the notice in the PRs RFC

@chenkins chenkins force-pushed the feature/fix-tag-when-run-on-push-to-main branch from 3d32a31 to 54d41bf Compare February 13, 2025 11:06
@chenkins chenkins enabled auto-merge (squash) February 13, 2025 11:06
@chenkins
Copy link
Contributor Author

The changes look good but I don't see how it's linked to the notice in the PRs RFC

Not directly related indeed

@chenkins chenkins requested a review from Holzchopf February 13, 2025 11:08
@chenkins chenkins merged commit 885a3ee into main Feb 13, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzchopf Holzchopf Holzchopf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenkins @Holzchopf