Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Complete env configure #175

Merged
merged 3 commits into from
Mar 7, 2025
Merged

ci: Complete env configure #175

merged 3 commits into from
Mar 7, 2025

Conversation

Holzchopf
Copy link
Contributor

Changes

Added the possibility to provide KEYCLOAK_PORT in docker-compose.yml and REDIS_PORT in both docker compose files.

Related issues

Closes #172

Request for Comment

  • Risk: low - all references to KEYCLOAK_PORT and REDIS_PORT have fallback values, so there's no impact when using the current .env and there's no requirement to update the current .env.
  • Discussion: low

Checklist

  • Document changes in this pull request above.
  • Documentation is added in the docs folder for relevant behavior changes.
  • Technical guidelines listed in docs/CONTRIBUTING.md are followed.

@Holzchopf Holzchopf requested a review from a team as a code owner March 6, 2025 15:50
@Holzchopf Holzchopf requested a review from chenkins March 6, 2025 15:50
Copy link
Contributor

@chenkins chenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Holzchopf Holzchopf enabled auto-merge (squash) March 7, 2025 07:17
@Holzchopf Holzchopf merged commit 0f4e9f5 into main Mar 7, 2025
3 checks passed
@Holzchopf Holzchopf deleted the complete-env-configure branch March 7, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all ports in docker-compose.yml env-configurable
2 participants