-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
118 Add test_lru_cache_problem.py. #119
Conversation
65f5e0b
to
16e32c3
Compare
This solution looks good - unfortunately, I haven't been able to test it at runtime yet. However, I understand the fix. |
I checked out this branch. I am not sure whether we will encounter future issues. See the below log – of course, this is not yet adapted to the latest version (in this branch), but I am just wondering if the problem can be fixed when we inherit the RailEnv. (flatland-rl-test) u216993@K57156:~/flatland/test/flatland_solver_policy$ python example/flatland_dynamics/example_flatland_dynamics.py |
@aiAdrian you're using 3.8. There were changes to |
…idTransitionMap object lifecycle in sync with cache lifecycle.
…r eq/hash definition on instance methods.
3254dbd
to
6026a74
Compare
Changes
load_new
andload
.methodtools.lru_cache
for proper instance method caching. KeepGridTransitionMap
object lifecycle in sync with cache lifecycle.](118 Add test_lru_cache_problem.py. #119Related issues
Fixes #118.
First steps for #104
Checklist
[Unreleased]
tag inCHANGELOG.md
.pyproject.toml
file.Requirement files have been updated by running
tox -e requirements
.required to run successfully.
CONTRIBUTING.md
are followed.