Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: from attr import attr, attrs, attrib, Factory ImportError: cannot import name 'attrs' from 'attr' #127

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

chenkins
Copy link
Contributor

@chenkins chenkins commented Feb 20, 2025

Changes

  • Add test reproducing the error
  • Fix error from attr import attr, attrs, attrib, Factory ImportError: cannot import name 'attrs' from 'attr'

Related issues

Link to every issue from the issue tracker (if any) you addressed in this PR.

Checklist

  • Tests are included for relevant behavior changes.
  • Documentation is added in the flatland-book repo for relevant behavior changes.
  • If you made important user-facing changes, describe them under the [Unreleased] tag in CHANGELOG.md.
  • New package dependencies are declared in the pyproject.toml file.
    Requirement files have been updated by running tox -e requirements.
  • Code works with all supported Python versions (3.10, 3.11 and 3.12). Checks run with all three version and are
    required to run successfully.
  • Code is formatted according to PEP 8 (an IDE like PyCharm can do this for you).
  • Technical guidelines listed in CONTRIBUTING.md are followed.

@chenkins chenkins added this to the 4.0.5 milestone Feb 20, 2025
@chenkins chenkins requested a review from Holzchopf February 20, 2025 09:21
@chenkins chenkins changed the title Add tox env verifying plain install (without dev requirements). fix: from attr import attr, attrs, attrib, Factory ImportError: cannot import name 'attrs' from 'attr' Feb 20, 2025
Holzchopf
Holzchopf previously approved these changes Feb 20, 2025
@chenkins chenkins marked this pull request as ready for review February 20, 2025 09:52
@chenkins chenkins requested a review from a team as a code owner February 20, 2025 09:52
@chenkins chenkins merged commit 248928b into main Feb 20, 2025
6 checks passed
@chenkins chenkins deleted the feature/fix-attr-requirement branch February 20, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants