Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

140 Rail, Line and Timetable from File Generators. #141

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

140 Rail, Line and Timetable from File Generators. #141

wants to merge 14 commits into from
+263 −3

Conversation

chenkins
Copy link
Contributor

@chenkins chenkins commented Mar 3, 2025 •
edited
Loading

Changes

  • Add FileRailFromGridGen.
  • Add FileTimetableGenerator.
  • Add FileLineGenerator.
  • Add test using rail, line and timetable generator from file.

Related issues

Closes #140

Checklist

  • Tests are included for relevant behavior changes.
  • Documentation is added in the flatland-book repo for relevant behavior changes.
  • If you made important user-facing changes, describe them under the [Unreleased] tag in CHANGELOG.md.
  • New package dependencies are declared in the pyproject.toml file.
    Requirement files have been updated by running tox -e requirements.
  • Code works with all supported Python versions (3.10, 3.11 and 3.12). Checks run with all three version and are
    required to run successfully.
  • Code is formatted according to PEP 8 (an IDE like PyCharm can do this for you).
  • Technical guidelines listed in CONTRIBUTING.md are followed.

@chenkins chenkins requested a review from CleverManu March 3, 2025 16:33
@chenkins chenkins changed the title 140 Rail and Schedule Generator from File. 140 Rail and Schedule Timetable from File. Mar 3, 2025
@chenkins chenkins changed the title 140 Rail and Schedule Timetable from File. 140 Rail, Line and Timetable Generators from File. Mar 3, 2025
@chenkins chenkins changed the title 140 Rail, Line and Timetable Generators from File. 140 Rail, Line and Timetable from File Generators. Mar 3, 2025
@chenkins chenkins added this to the 4.0.6 milestone Mar 4, 2025
@chenkins chenkins marked this pull request as ready for review March 4, 2025 14:31
@chenkins chenkins requested a review from a team as a code owner March 4, 2025 14:31
@chenkins chenkins force-pushed the 140-rail-and-schedule-generator-from-file branch from c5d5e56 to 6e9f49d Compare March 5, 2025 07:09
@chenkins chenkins modified the milestones: 4.0.6, 4.0.5 Mar 5, 2025
Holzchopf
Holzchopf reviewed Mar 5, 2025
View reviewed changes
@chenkins chenkins requested a review from a team March 5, 2025 08:53
@chenkins chenkins modified the milestones: 4.0.5, 4.0.6 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzchopf Holzchopf Holzchopf left review comments

@CleverManu CleverManu Awaiting requested review from CleverManu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.6
Development

Successfully merging this pull request may close these issues.

Rail, Line and Timetable from file generators.
2 participants
@chenkins @Holzchopf