Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip CIDSet generation for PDF/A3 subset #1563

Closed
wants to merge 1 commit into from

Conversation

florianbepunkt
Copy link
Contributor

Fixes the second part of #1561. CIDSet is only generated for PDF/A subsets 1 and 2 (not 100% sure if it could be skipped for 2 as well).

I followed the contributing guide, but this did not work. All tests failed due to some jest config problem:

Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

Is the contributing guide up-to-date?

@blikblum
Copy link
Member

blikblum commented Nov 7, 2024

Is the contributing guide up-to-date?

Yarn should be used.

A (simple) unit test with ranges in subsets 1, 2 and 3 are welcome

@smartmeta
Copy link

smartmeta commented Dec 5, 2024

Would be nice to see this (and #1561) merged

@skch-17
Copy link

skch-17 commented Dec 10, 2024

The same issue exists for subset 2.

@florianbepunkt Should the whole fix be applied for < 2?

@florianbepunkt
Copy link
Contributor Author

The same issue exists for subset 2.

@florianbepunkt Should the whole fix be applied for < 2?

I believe so, but not 100% sure.

@carstenblt
Copy link

Indeed, validators complain when set to PDF/A-2 & PDF/A-3, but not PDF/A-1.

Can this be merged? I believe a lot of people are waiting for this to be able to create ZUGFeRD documents.

@liborm85
Copy link
Collaborator

Fixed by #1561 (comment)

@liborm85 liborm85 closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants