Skip to content

Clean-up lint warnings #5

Clean-up lint warnings

Clean-up lint warnings #5

Triggered via push January 24, 2025 20:34
Status Failure
Total duration 1m 42s
Artifacts

test.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 2 warnings
Lint: internal/smtpconn/smtpconn.go#L532
unnecessary leading newline (whitespace)
Lint: internal/auth/auth_test.go#L78
The copy of the 'for' variable "case_" can be deleted (Go 1.22+) (copyloopvar)
Lint: internal/target/remote/remote_test.go#L1023
SA1019: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (staticcheck)
Lint: internal/target/smtp/smtp_downstream_test.go#L347
SA1019: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (staticcheck)
Lint
issues found
Build and test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Verify build.sh
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636