Merge pull request #766 from johnweldon/jw4/fix-logger-errors

framework/log: Fix Logger usages in tests
foxcpp · Feb 22, 2025 · 9cf2adb · 9cf2adb
2 parents 95ba6bf + 4a5f379
commit 9cf2adb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/internal/storage/blob/test_blob.go b/internal/storage/blob/test_blob.go
@@ -39,10 +39,11 @@ func TestStore(t *testing.T, newStore func() module.BlobStore, cleanStore func(m
 		prng := rand.New(randSrc)
 		store := newStore()
 
+		l := testutils.Logger(t, "imapsql")
 		b, err := imapsql.New("sqlite3", ":memory:",
 			imapsql2.ExtBlobStore{Base: store}, imapsql.Opts{
 				PRNG: prng,
-				Log:  testutils.Logger(t, "imapsql"),
+				Log:  &l,
 			},
 		)
 		if err != nil {

diff --git a/internal/target/remote/dane_delivery_test.go b/internal/target/remote/dane_delivery_test.go
@@ -32,7 +32,8 @@ import (
 )
 
 func targetWithExtResolver(t *testing.T, zones map[string]mockdns.Zone) (*mockdns.Server, *Target) {
-	dnsSrv, err := mockdns.NewServerWithLogger(zones, testutils.Logger(t, "mockdns"), false)
+	l := testutils.Logger(t, "mockdns")
+	dnsSrv, err := mockdns.NewServerWithLogger(zones, &l, false)
 	if err != nil {
 		t.Fatal(err)
 	}

diff --git a/internal/target/remote/mxauth_test.go b/internal/target/remote/mxauth_test.go
@@ -303,7 +303,8 @@ func TestRemoteDelivery_AuthMX_DNSSEC(t *testing.T) {
 		},
 	}
 
-	dnsSrv, err := mockdns.NewServerWithLogger(zones, testutils.Logger(t, "mockdns"), false)
+	l := testutils.Logger(t, "mockdns")
+	dnsSrv, err := mockdns.NewServerWithLogger(zones, &l, false)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -342,7 +343,8 @@ func TestRemoteDelivery_AuthMX_DNSSEC_Fail(t *testing.T) {
 		},
 	}
 
-	dnsSrv, err := mockdns.NewServerWithLogger(zones, testutils.Logger(t, "mockdns"), false)
+	l := testutils.Logger(t, "mockdns")
+	dnsSrv, err := mockdns.NewServerWithLogger(zones, &l, false)
 	if err != nil {
 		t.Fatal(err)
 	}