Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#277 initial helm chart implementation #278

Closed
wants to merge 8 commits into from
Closed

#277 initial helm chart implementation #278

wants to merge 8 commits into from

Conversation

acim
Copy link
Contributor

@acim acim commented Oct 1, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #278 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   52.31%   52.29%   -0.03%     
==========================================
  Files         101      101              
  Lines        8064     8064              
==========================================
- Hits         4219     4217       -2     
- Misses       3329     3330       +1     
- Partials      516      517       +1     
Flag Coverage Δ
#integration 22.42% <ø> (ø)
#unit 57.38% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/target/queue/timewheel.go 92.72% <0.00%> (-3.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324a3b3...218de0a. Read the comment docs.

@foxcpp foxcpp linked an issue Oct 1, 2020 that may be closed by this pull request
1 task
@foxcpp foxcpp changed the base branch from master to dev October 1, 2020 19:33
@acim acim changed the base branch from dev to master October 2, 2020 11:01
@acim acim marked this pull request as ready for review October 2, 2020 11:02
@acim acim mentioned this pull request Oct 2, 2020
1 task
@acim
Copy link
Contributor Author

acim commented Oct 3, 2020

Just tested locally using kind:

kubectl create secret tls maddy --cert=fullchain.pem --key=privkey.pem
helm upgrade --install maddy ./chart

and it runs happily:

smtp: listening on tcp://0.0.0.0:25	
sign_dkim: generating a new rsa2048 keypair...	
sign_dkim: generated a new rsa2048 keypair, private key is in dkim_keys/example.org_default.key, TXT record with public key is in dkim_keys/example.org_default.dns,
put its contents into TXT record for default._domainkey.example.org to make signing and verification work	
submission: listening on tls://0.0.0.0:465	
submission: listening on tcp://0.0.0.0:587	
imap: listening on tls://0.0.0.0:993	
imap: listening on tcp://0.0.0.0:143

@foxcpp
Copy link
Owner

foxcpp commented Oct 3, 2020

Okay, I have no way of actually testing it so I will take your word for it. :)

@foxcpp foxcpp changed the base branch from master to dev October 3, 2020 08:49
@foxcpp
Copy link
Owner

foxcpp commented Oct 3, 2020

Eeh, switching base branch messed it up. I will go merge it manually, I suppose...

@foxcpp
Copy link
Owner

foxcpp commented Oct 3, 2020

Merged manually as 2b0fecb.

@foxcpp foxcpp closed this Oct 3, 2020
@acim acim deleted the feature/277-helm-chart branch October 5, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart for Kubernetes installation
4 participants