feat(modify): new modifier add_header
#771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msessa
changed the title
add_header
foxcpp
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Overall LGTM. Can you add a configuration option to not return an error on duplicate header? It is correct to have multiple values for some header fields and such configuration option may be useful for some cases. I would probably make it default even as "least surprise" principle.
|
@foxcpp thanks for you review (and for creating maddy!) I didn't realize the spec permitted fields appearing multiple times. |
|
btw I'm happy to also implement other variations of the modifier, eg: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #158
Description
This PR adds a new modifier
add_headerwhich allows arbitrary headers to be added to a message in the pipeline.Use Case
A practical use case is to inject the
X-SES-FROM-ARNheader before forwarding the message to AWS SES to control which identity will be used to verify the sender domain.See reference here