Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Unflake LCP test #13741

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix(test): Unflake LCP test #13741

merged 1 commit into from
Sep 23, 2024

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Sep 20, 2024

Moved assertions inside a conditional where the lcp.element is the image, not the button (It's worked around like this in other test suites). I guess this flakiness is behavioural not about the tests.

@onurtemizkan onurtemizkan force-pushed the onur/fix-lcp-flakes branch 4 times, most recently from 99868e0 to 0ab678b Compare September 21, 2024 07:01
Copy link

codecov bot commented Sep 21, 2024

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
616 4 612 29
View the top 3 failed tests by shortest run time
nested-rsc-error.test.ts Should capture errors from nested server components when `Sentry.captureRequestError` is added to the `onRequestError` hook
Stack Traces | 120s run time
nested-rsc-error.test.ts:6:5 Should capture errors from nested server components when `Sentry.captureRequestError` is added to the `onRequestError` hook
streaming-rsc-error.test.ts Should capture errors for crashing streaming promises in server components when `Sentry.captureRequestError` is added to the `onRequestError` hook
Stack Traces | 120s run time
streaming-rsc-error.test.ts:6:5 Should capture errors for crashing streaming promises in server components when `Sentry.captureRequestError` is added to the `onRequestError` hook
ppr-error.test.ts should not capture React-internal errors for PPR rendering
Stack Traces | 120s run time
ppr-error.test.ts:4:5 should not capture React-internal errors for PPR rendering

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@onurtemizkan onurtemizkan marked this pull request as ready for review September 23, 2024 05:53
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now, thanks for fixing!

Ideally, this gets more stable with #12714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants