fix(nuxt): Use Nuxt error hooks instead of errorHandler to prevent 500 #13748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
requested review from
Lms24,
a team,
stephanie-anderson and
chargome
and removed request for
a team and
stephanie-anderson
size-limit report 📦
|
Lms24
approved these changes
Sep 23, 2024
Comment on lines
+39
to
+41
| // Check if the current `app.config.errorHandler` is explicitly set by the user before calling it. | ||
| if (typeof originalErrorHandler === 'function' && app.config.errorHandler) { | ||
| (originalErrorHandler as UnknownFunc).call(app, error, vm, lifecycleHook); |
There was a problem hiding this comment.
l: I guess technically, we don't need this check here for Nuxt, right? Given we don't attach the error handler anymore.
There was a problem hiding this comment.
Yeah, this part is not related to Nuxt anymore. But I thought it still make sense to check if currently there is an error handler attached.
Co-authored-by: Lukas Stracke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option
attachErrorHandlerto thevueIntegration. This option is used in the Nuxt SDK to prevent wrapping the existing Nuxt error handler. Instead, the errors are captured in the Nuxt hooks.fixes: #12515