Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Resolve path for dynamic webpack import #13751

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

chargome
Copy link
Member

@chargome chargome commented Sep 23, 2024

This PR handles the dynamic import of modules using require.resolve instead of a hardcoded node_modules path allowing the use of alternative node linkers like Yarn Pn

Conditionally calls the dynamic webpack import

fixes #13641

@chargome chargome self-assigned this Sep 23, 2024
@OllieJennings
Copy link

@chargome l was wondering if this could get brought back to life? As it looks like Sentry v8 for NextJS doesn't work in mono-repos where the node_modules get hoisted

@chargome
Copy link
Member Author

@OllieJennings we're currently busy working on a bigger change in the Next.js SDK, I will re-visit this afterwards (there are still tests failing atm) – I know this is a painful issue if you're working with hoisted dependencies right now

Copy link
Contributor

github-actions bot commented Oct 16, 2024

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.76 KB - -
@sentry/browser - with treeshaking flags 21.54 KB - -
@sentry/browser (incl. Tracing) 35.15 KB - -
@sentry/browser (incl. Tracing, Replay) 71.87 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.29 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.18 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.98 KB - -
@sentry/browser (incl. Feedback) 39.9 KB - -
@sentry/browser (incl. sendFeedback) 27.4 KB - -
@sentry/browser (incl. FeedbackAsync) 32.2 KB - -
@sentry/react 25.51 KB - -
@sentry/react (incl. Tracing) 38.12 KB - -
@sentry/vue 26.9 KB - -
@sentry/vue (incl. Tracing) 37.04 KB - -
@sentry/svelte 22.9 KB - -
CDN Bundle 24.1 KB - -
CDN Bundle (incl. Tracing) 36.97 KB - -
CDN Bundle (incl. Tracing, Replay) 71.63 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.97 KB - -
CDN Bundle - uncompressed 70.66 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.73 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.25 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.46 KB - -
@sentry/nextjs (client) 38.2 KB - -
@sentry/sveltekit (client) 35.75 KB - -
@sentry/node 131.52 KB - -
@sentry/node - without tracing 95.64 KB - -
@sentry/aws-serverless 105.91 KB -0.01% -1 B 🔽

View base workflow run

Copy link

codecov bot commented Nov 4, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
642 2 640 30
View the top 2 failed tests by shortest run time
app-router/rsc-error.test.ts Should capture errors from server components
Stack Traces | 120s run time
rsc-error.test.ts:4:5 Should capture errors from server components
pages-router/client-trace-propagation.test.ts Should propagate traces from server to client in pages router
Stack Traces | 120s run time
client-trace-propagation.test.ts:4:5 Should propagate traces from server to client in pages router

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@chargome chargome marked this pull request as ready for review November 5, 2024 11:56
@chargome chargome requested a review from lforst November 5, 2024 11:56
@chargome
Copy link
Member Author

chargome commented Nov 5, 2024

@lforst lol this approach worked locally with yarn pnp

Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this checks out

@chargome chargome merged commit ff18dfd into develop Nov 5, 2024
151 checks passed
@chargome chargome deleted the cg/fix-yarn-pnp branch November 5, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sentry/nextjs build fails on Yarn PnP mode
3 participants