fix(core): Remove sampled flag from dynamic sampling context in Tracing without Performance mode
#13753
+46
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout Performance mode
Lms24
changed the title
sampled flag from baggage meta tag in Tracing without Performance modesampled flag from baggage meta tag in Tracing without Performance mode
Lms24
changed the title
sampled flag from baggage meta tag in Tracing without Performance modesampled flag from dynamic sampling context in Tracing without Performance mode
Lms24
commented
Sep 23, 2024
| @@ -27,5 +27,6 @@ describe('getTraceMetaTags', () => { | |||
| expect(sentryBaggageContent).toContain('sentry-environment=production'); | |||
| expect(sentryBaggageContent).toContain('sentry-public_key=public'); | |||
| expect(sentryBaggageContent).toContain(`sentry-trace_id=${traceId}`); | |||
| expect(sentryBaggageContent).not.toContain('sentry-sampled='); | |||
There was a problem hiding this comment.
This assertion failed before the change in this PR
size-limit report 📦
|
mydea
reviewed
Sep 24, 2024
| metaTags: Sentry.getTraceMetaTags(), | ||
| }, | ||
| }; | ||
| if (!event.contexts.traceData) { |
There was a problem hiding this comment.
Actually, two of the tests have become so similar that I'll just remove the beforeSend hook and one of the tests.
mydea
reviewed
Sep 24, 2024
|
|
||
| expect(traceData.metaTags).toContain(`<meta name="sentry-trace" content="${trace_id}-${span_id}"/>`); | ||
| expect(traceData.metaTags).toContain(`sentr y-trace_id=${trace_id}`); |
There was a problem hiding this comment.
yeah, it "passed" because the test function was async but it should have been sync and passed done to the runner. So I guess the assertion failed eventually but at that point the test already passed and we never saw any failing logs 😬
mydea
approved these changes
Sep 24, 2024
Lms24
deleted the
lms/fix-core-getDynamicSamplingContextFromSpan-unsampled-span
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in Core that surfaced in Node apps configured for Tracing without Performance.
Previously, we'd incorrectly add
sampled: falseflag when creating the DSC from an active span if the application was configured for TwP. This is possible because in TwP, Otel still emits non-recording spans for the incoming requests. Our implementation in Core didn't account for this edge case yet.This PR also adds a regression test and fixes some previously incorrectly passing tests.