fix(nuxt): Use absolute path for client config #13798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
requested review from
Lms24,
a team and
lforst
and removed request for
a team
Lms24
approved these changes
Sep 25, 2024
packages/nuxt/src/vite/utils.ts
Outdated
| @@ -24,5 +24,5 @@ export function findDefaultSdkInitFile(type: 'server' | 'client'): string | unde | |||
|
|
|||
| const filePath = filePaths.find(filename => fs.existsSync(filename)); | |||
|
|
|||
| return filePath ? path.basename(filePath) : undefined; | |||
| return filePath ? filePath : undefined; | |||
There was a problem hiding this comment.
l: doesn't find() already return undefined? If so we probably don't need the ternary here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
buildDircan be changed in Nuxt and Adding the client config with a relative path worked so far as thebuildDirin Nuxt v3 is/<rootDir>/.nuxtbut thebuildDircan be modified by the user and is also different in Nuxt v4 (/<rootDir>/node_modules/.cache/nuxt/.nuxt).By using the absolute path, the client config can be injected correctly with all
buildDirvariations