Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Clear fallback buffer when switching buffers #13914

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Oct 8, 2024

Saw this while debugging, this should not have a big effect since the fallback buffer should be relatively small.

Saw this while debugging, this should not have a big effect since the fallback buffer should be relatively small.
Copy link
Contributor

github-actions bot commented Oct 8, 2024

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.73 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 34.97 KB - -
@sentry/browser (incl. Tracing, Replay) 71.55 KB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.95 KB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 75.88 KB +0.01% +6 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 88.64 KB +0.01% +5 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.51 KB +0.01% +5 B 🔺
@sentry/browser (incl. metrics) 27 KB - -
@sentry/browser (incl. Feedback) 39.87 KB - -
@sentry/browser (incl. sendFeedback) 27.38 KB - -
@sentry/browser (incl. FeedbackAsync) 32.17 KB - -
@sentry/react 25.49 KB - -
@sentry/react (incl. Tracing) 37.94 KB - -
@sentry/vue 26.9 KB - -
@sentry/vue (incl. Tracing) 36.86 KB - -
@sentry/svelte 22.87 KB - -
CDN Bundle 24.05 KB - -
CDN Bundle (incl. Tracing) 36.76 KB - -
CDN Bundle (incl. Tracing, Replay) 71.3 KB +0.01% +6 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.61 KB +0.02% +8 B 🔺
CDN Bundle - uncompressed 70.53 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.04 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 221.14 KB +0.01% +16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 234.36 KB +0.01% +16 B 🔺
@sentry/nextjs (client) 37.91 KB - -
@sentry/sveltekit (client) 35.56 KB - -
@sentry/node 124.5 KB - -
@sentry/node - without tracing 93.64 KB - -
@sentry/aws-serverless 103.29 KB - -

View base workflow run

@billyvg billyvg marked this pull request as ready for review October 8, 2024 22:42
@billyvg billyvg requested a review from a team as a code owner October 8, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants