fix(replay): Fix onError sampling when loading an expired buffered session #13962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion This fixes a bug where an older, saved session (that has a `previousSessionId`, i.e. session was recorded and expired) would cause buffered replays to not send when an error happens. This is because the session start timestamp would never update, causing our flush logic to skip sending the replay due to incorrect replay duration calculation.
billyvg
commented
Oct 11, 2024
Comment on lines
-74
to
-82
| // If there is a previousSessionId after a full snapshot occurs, then | ||
| // the replay session was started due to session expiration. The new session | ||
| // is started before triggering a new checkout and contains the id | ||
| // of the previous session. Do not immediately flush in this case | ||
| // to avoid capturing only the checkout and instead the replay will | ||
| // be captured if they perform any follow-up actions. | ||
| if (session && session.previousSessionId) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
This bug was so simple and right there this entire time 😭
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
billyvg
deleted the
fix-replay-buffered-session-start-time-not-updating-loading-existing-session
branch
billyvg
added a commit
that referenced
this pull request
Oct 17, 2024
…ssion (#13962) This fixes a bug where an older, saved session (that has a `previousSessionId`, i.e. session was recorded and expired) would cause buffered replays to not send when an error happens. This is because the session start timestamp would never update, causing our flush logic to skip sending the replay due to incorrect replay duration calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where an older, saved session (that has a
previousSessionId, i.e. session was recorded and expired) would cause buffered replays to not send when an error happens. This is because the session start timestamp would never update, causing our flush logic to skip sending the replay due to incorrect replay duration calculation.