Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Ensure errors thrown in async cron jobs bubble up #14182

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

andreiborza
Copy link
Member

@andreiborza andreiborza commented Nov 5, 2024

Copy link

codecov bot commented Nov 5, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
642 1 641 31
View the top 1 failed tests by shortest run time
cron-decorator.test.ts Sends exceptions to Sentry on error in cron job
Stack Traces | 30s run time
cron-decorator.test.ts:65:5 Sends exceptions to Sentry on error in cron job

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@andreiborza andreiborza marked this pull request as ready for review November 5, 2024 11:12
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the test as well!

@andreiborza andreiborza merged commit e1c49dc into develop Nov 5, 2024
151 checks passed
@andreiborza andreiborza deleted the ab/core-cron-capture-exceptions branch November 5, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error thrown in Nest.JS cron job is not being reported in Sentry
2 participants