Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(vue): Reduce bundle size for starting application render span #14275

Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 13, 2024

Just a smal bundle size reduction PR for the Vue SDK: I discovered while working on #14251 that we can simplify the check here and just use the onlyIfParent flag instead of querying the active span. This should behave identically.

@Lms24 Lms24 self-assigned this Nov 13, 2024
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.77 KB added added
@sentry/browser - with treeshaking flags 21.53 KB added added
@sentry/browser (incl. Tracing) 35.26 KB added added
@sentry/browser (incl. Tracing, Replay) 71.98 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.35 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 76.31 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 89.14 KB added added
@sentry/browser (incl. Feedback) 39.93 KB added added
@sentry/browser (incl. sendFeedback) 27.42 KB added added
@sentry/browser (incl. FeedbackAsync) 32.23 KB added added
@sentry/react 25.52 KB added added
@sentry/react (incl. Tracing) 38.22 KB added added
@sentry/vue 26.91 KB added added
@sentry/vue (incl. Tracing) 37.09 KB added added
@sentry/svelte 22.91 KB added added
CDN Bundle 24.13 KB added added
CDN Bundle (incl. Tracing) 37.04 KB added added
CDN Bundle (incl. Tracing, Replay) 71.7 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 77.05 KB added added
CDN Bundle - uncompressed 70.73 KB added added
CDN Bundle (incl. Tracing) - uncompressed 109.9 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.42 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.64 KB added added
@sentry/nextjs (client) 38.33 KB added added
@sentry/sveltekit (client) 35.84 KB added added
@sentry/node 134.28 KB added added
@sentry/node - without tracing 96.46 KB added added
@sentry/aws-serverless 106.72 KB added added

@Lms24 Lms24 marked this pull request as ready for review November 13, 2024 15:37
@Lms24 Lms24 requested review from a team, stephanie-anderson, AbhiPrasad and mydea and removed request for a team and stephanie-anderson November 13, 2024 15:37
@Lms24 Lms24 merged commit 1434fd9 into develop Nov 14, 2024
127 checks passed
@Lms24 Lms24 deleted the lms/ref-vue-tracing-onlyifparent-application-render-span branch November 14, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants