Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nestjs): Deprecate @WithSentry in favor of @SentryExceptionCaptured #14323

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 15, 2024

Ref #14293

@lforst lforst mentioned this pull request Nov 15, 2024
3 tasks
Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.8 KB - -
@sentry/browser - with treeshaking flags 21.57 KB - -
@sentry/browser (incl. Tracing) 35.31 KB - -
@sentry/browser (incl. Tracing, Replay) 72.06 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.43 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.35 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.79 KB - -
@sentry/browser (incl. Feedback) 39.56 KB +0.01% +1 B 🔺
@sentry/browser (incl. sendFeedback) 27.45 KB - -
@sentry/browser (incl. FeedbackAsync) 32.27 KB - -
@sentry/react 25.58 KB - -
@sentry/react (incl. Tracing) 38.26 KB - -
@sentry/vue 26.95 KB - -
@sentry/vue (incl. Tracing) 37.14 KB - -
@sentry/svelte 22.94 KB - -
CDN Bundle 24.16 KB +0.02% +3 B 🔺
CDN Bundle (incl. Tracing) 37.11 KB - -
CDN Bundle (incl. Tracing, Replay) 71.78 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.12 KB - -
CDN Bundle - uncompressed 70.86 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.07 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.59 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.81 KB - -
@sentry/nextjs (client) 38.37 KB - -
@sentry/sveltekit (client) 35.88 KB - -
@sentry/node 134.4 KB -0.01% -1 B 🔽
@sentry/node - without tracing 96.25 KB - -
@sentry/aws-serverless 106.54 KB - -

View base workflow run

@chargome
Copy link
Member

What is the reason for creating the deprecation pr separately?

Base automatically changed from lforst-with-sentry-alias to develop November 18, 2024 08:42
@lforst
Copy link
Member Author

lforst commented Nov 18, 2024

What is the reason for creating the deprecation pr separately?

It gives us the possibilty to publish a version that has the migration path layed out, so that we can update the docs in peace to point to the newer version.

That way we never have docs that tell people to use a deprecated thing. This is one of the learnings we had in v8. For things that we expect to have close to 0 direct usage we can skip this circus but I assume this has a lot of usage.

@lforst lforst merged commit a78a2d2 into develop Nov 19, 2024
41 checks passed
@lforst lforst deleted the lforst-deprecate-with-sentry branch November 19, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants