Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): Remove replay id from DSC on expired sessions #14342

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

chargome
Copy link
Member

Since #13893, the replayId is deleted from the DSC whenever stop is called on replay.

With this PR we additionally delete the replay on the DSC whenever we encounter an expired session in the event processor.

ref #13778 (comment)

@chargome chargome self-assigned this Nov 18, 2024
@chargome chargome requested a review from a team as a code owner November 18, 2024 12:32
Copy link
Contributor

github-actions bot commented Nov 18, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.77 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 35.27 KB - -
@sentry/browser (incl. Tracing, Replay) 72 KB +0.02% +13 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.38 KB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.31 KB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.17 KB +0.02% +18 B 🔺
@sentry/browser (incl. Feedback) 39.93 KB - -
@sentry/browser (incl. sendFeedback) 27.42 KB - -
@sentry/browser (incl. FeedbackAsync) 32.23 KB - -
@sentry/react 25.52 KB - -
@sentry/react (incl. Tracing) 38.23 KB +0.01% +1 B 🔺
@sentry/vue 26.92 KB - -
@sentry/vue (incl. Tracing) 37.1 KB - -
@sentry/svelte 22.91 KB - -
CDN Bundle 24.13 KB - -
CDN Bundle (incl. Tracing) 37.05 KB - -
CDN Bundle (incl. Tracing, Replay) 71.72 KB +0.01% +7 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 77.07 KB +0.02% +8 B 🔺
CDN Bundle - uncompressed 70.73 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.93 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.46 KB +0.01% +9 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.68 KB +0.01% +9 B 🔺
@sentry/nextjs (client) 38.35 KB - -
@sentry/sveltekit (client) 35.85 KB - -
@sentry/node 134.33 KB - -
@sentry/node - without tracing 96.2 KB - -
@sentry/aws-serverless 106.48 KB - -

View base workflow run

@chargome chargome merged commit da5b2e0 into develop Nov 19, 2024
151 checks passed
@chargome chargome deleted the cg/reset-replay-id-on-expired-session branch November 19, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants