Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utils/core): Deprecate addRequestDataToEvent and extractRequestData #14430

Merged
merged 3 commits into from
Nov 22, 2024
Merged

feat(utils/core): Deprecate addRequestDataToEvent and extractRequestData #14430

merged 3 commits into from
Nov 22, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 22, 2024

Ref #14267

Deprecates addRequestDataToEvent and extractRequestData which are problematic API wise and have a more structured replacement.

@lforst lforst mentioned this pull request Nov 22, 2024
Closed
13 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
654 1 653 29
View the top 1 failed tests by shortest run time 
integrations/ContextLines/noAddedLines/test.ts should not add source context lines to errors from script files
Stack Traces | 30s run time 
test.ts:6:11 should not add source context lines to errors from script files

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@lforst lforst requested review from mydea and andreiborza November 22, 2024 11:37
@lforst lforst merged commit d49f1cb into develop Nov 22, 2024
151 of 152 checks passed
@lforst lforst deleted the lforst-depr-ardte branch November 22, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@andreiborza andreiborza Awaiting requested review from andreiborza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @mydea