Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentelemetry): Set response context for http.server spans #14634

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 10, 2024

This implements the response context for http.server spans (https://develop.sentry.dev/sdk/data-model/event-payloads/contexts/#response-context).

I opted to not implement this for the browser, as we do not really expect server spans there. I added a test there anyhow to show the shape of the transaction event, so we can adjust this easier if we want in the future.

Closes #14619
Closes #14634

@mydea mydea requested a review from AbhiPrasad December 10, 2024 09:18
@mydea mydea self-assigned this Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.27 KB - -
@sentry/browser - with treeshaking flags 21.94 KB - -
@sentry/browser (incl. Tracing) 35.75 KB - -
@sentry/browser (incl. Tracing, Replay) 72.98 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.38 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.29 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.78 KB - -
@sentry/browser (incl. Feedback) 40.02 KB - -
@sentry/browser (incl. sendFeedback) 27.88 KB - -
@sentry/browser (incl. FeedbackAsync) 32.67 KB - -
@sentry/react 25.94 KB - -
@sentry/react (incl. Tracing) 38.58 KB - -
@sentry/vue 27.47 KB - -
@sentry/vue (incl. Tracing) 37.59 KB - -
@sentry/svelte 23.43 KB - -
CDN Bundle 24.41 KB - -
CDN Bundle (incl. Tracing) 37.4 KB - -
CDN Bundle (incl. Tracing, Replay) 72.6 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.96 KB - -
CDN Bundle - uncompressed 71.69 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.97 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.04 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.26 KB - -
@sentry/nextjs (client) 38.86 KB - -
@sentry/sveltekit (client) 36.26 KB - -
@sentry/node 162.39 KB +0.03% +39 B 🔺
@sentry/node - without tracing 98.56 KB +0.03% +27 B 🔺
@sentry/aws-serverless 126.26 KB +0.03% +36 B 🔺

View base workflow run

Copy link

codecov bot commented Dec 10, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
690 1 689 301
View the top 1 failed tests by shortest run time
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes
Stack Traces | 30s run time
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@mydea mydea merged commit 3339829 into develop Dec 11, 2024
157 checks passed
@mydea mydea deleted the fn/responseContext branch December 11, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

response context not set on Node SDKs
2 participants