feat(v8/react): Add support for React Router createMemoryRouter
#14985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
commented
Jan 13, 2025
packages/react/src/reactrouterv6.tsx
Outdated
Comment on lines
67
to
72
| /** | ||
| * Alias for consistency with `wrapCreateBrowserRouter` | ||
| * @deprecated Use `wrapCreateMemoryRouterV6` or `wrapCreateMemoryRouterV7` instead. | ||
| */ | ||
| export const wrapCreateMemoryRouter = wrapCreateMemoryRouterV6; | ||
|
|
There was a problem hiding this comment.
Added this alias here for consistency.
onurtemizkan
changed the title
createMemoryRouter (#14854)createMemoryRouter (#14854)
lforst
approved these changes
Jan 15, 2025
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
lforst
changed the title
createMemoryRouter (#14854)createMemoryRouter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #14854 to
v8