Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v8/aws-lambda): Avoid overwriting root span name #15054

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 17, 2025

backport of #15000

Calls `scope.updateTransactionName`
which updates the error location "transaction" name on the scope. This
is only applied to error events during event processing, so the
intention is clearer than adding an event processor.
@Lms24 Lms24 requested review from andreiborza, a team and lforst and removed request for a team January 17, 2025 13:08
@Lms24 Lms24 changed the title fix(v8/aws-lambda): Avoid overwriting root span name (#15000) fix(v8/aws-lambda): Avoid overwriting root span name Jan 17, 2025
@Lms24 Lms24 self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
695 1 694 301
View the full list of 1 ❄️ flaky tests
tracing/request/fetch/test.ts should create spans for fetch requests

Flake rate in main: 13.24% (Passed 59 times, Failed 9 times)

Stack Traces | 10.1s run time
test.ts:7:11 should create spans for fetch requests

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants