feat(core): Add addLink(s) to Sentry span
#15452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
approved these changes
Feb 21, 2025
| } | ||
|
|
||
| const url = await getLocalTestUrl({ testDir: __dirname }); | ||
| const [rootSpan1, rootSpan2] = await getMultipleSentryEnvelopeRequests<Event>(page, 3, { url }); |
There was a problem hiding this comment.
if we need to wait for 3 events here (do we?) but only want 2, my gut feeling tells me that there's room for flakes. Let's use the waitForTransactionRequest helper instead and check for the correct transaction (or some other identifier). This should be safer for flakes and makes things more explicit.
(side note: I think we should generally use this helper more often, as it works out really well in our e2e tests. But obviously, no action required, we can do this iteratively and over time)
| } | ||
|
|
||
| const url = await getLocalTestUrl({ testDir: __dirname }); | ||
| const [rootSpan1, rootSpan2, rootSpan3] = await getMultipleSentryEnvelopeRequests<Event>(page, 3, { url }); |
There was a problem hiding this comment.
If I understand this test correctly, we're sending 4 transaction events here, right? waiting on 3 then also introduces a potential flake as we depend on events being sent in the correct order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #14991