feat(feedback) Allowing annotation via highlighting & masking #15484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows you to edit screenshots with highlight and hide boxes, with the ability to delete individual boxes and resize the page. This will replace the previous cropping and pen annotation.  Related to getsentry/sentry#69786
size-limit report 📦
|
billyvg
reviewed
Feb 24, 2025
Comment on lines
88
to
95
| let strokeColor; | ||
| const sentryFeedback = DOCUMENT.getElementById(feedbackId); | ||
| if (sentryFeedback) { | ||
| const computedStyle = getComputedStyle(sentryFeedback); | ||
| strokeColor = | ||
| computedStyle.getPropertyValue('--button-primary-background') || | ||
| computedStyle.getPropertyValue('--accent-background'); | ||
| } |
There was a problem hiding this comment.
Instead of passing in feedbackId, should probably pass in strokeColor so that we calculate it just once
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…e, clean up xindex/mousedown bug, refactor action/box/rect overload
billyvg
approved these changes
Mar 4, 2025
ryan953
commented
Mar 4, 2025
Comment on lines
+100
to
+101
| default: | ||
| break; |
There was a problem hiding this comment.
not needed because there are only two values for Action now
|
Looks ready! |
billyvg
added a commit
that referenced
this pull request
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of https://github.com/getsentry/sentry-javascript/pull/15424/files