Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix allowUrls and denyUrls for linked and aggregate exceptions #15521

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

lforst
Copy link
Member

@lforst lforst commented Feb 27, 2025

Fixes #15513

The allowUrls and denyUrls logic up until now only looked at the first entry in the values field of an error event which is complete bogus for aggregate errors and linked errors because the "root" event in the former is one without parent id and in the latter simply the latest entry in the values array.

Copy link
Contributor

github-actions bot commented Feb 27, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.12 KB +0.14% +32 B 🔺
@sentry/browser - with treeshaking flags 22.9 KB +0.15% +35 B 🔺
@sentry/browser (incl. Tracing) 36.18 KB +0.1% +34 B 🔺
@sentry/browser (incl. Tracing, Replay) 73.35 KB +0.04% +30 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.77 KB +0.05% +30 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.97 KB +0.05% +32 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 90.54 KB +0.04% +29 B 🔺
@sentry/browser (incl. Feedback) 40.26 KB +0.09% +34 B 🔺
@sentry/browser (incl. sendFeedback) 27.74 KB +0.12% +33 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.54 KB +0.1% +32 B 🔺
@sentry/react 24.93 KB +0.14% +34 B 🔺
@sentry/react (incl. Tracing) 38.07 KB +0.1% +38 B 🔺
@sentry/vue 27.36 KB +0.12% +33 B 🔺
@sentry/vue (incl. Tracing) 37.87 KB +0.09% +33 B 🔺
@sentry/svelte 23.15 KB +0.16% +36 B 🔺
CDN Bundle 24.32 KB +0.14% +33 B 🔺
CDN Bundle (incl. Tracing) 36.21 KB +0.11% +40 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.23 KB +0.05% +35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.4 KB +0.05% +34 B 🔺
CDN Bundle - uncompressed 71.09 KB +0.12% +85 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 107.47 KB +0.08% +85 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.74 KB +0.04% +85 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.3 KB +0.04% +85 B 🔺
@sentry/nextjs (client) 39.23 KB +0.09% +34 B 🔺
@sentry/sveltekit (client) 36.59 KB +0.09% +33 B 🔺
@sentry/node 142.12 KB +0.02% +22 B 🔺
@sentry/node - without tracing 95.54 KB +0.03% +24 B 🔺
@sentry/aws-serverless 119.89 KB +0.03% +26 B 🔺

View base workflow run

@lforst lforst merged commit 02e6d11 into develop Feb 27, 2025
149 of 150 checks passed
@lforst lforst deleted the lforst-allowdeny-linked-errors branch February 27, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry 9.2 ignores allowUrls and reports errors anyway
2 participants