Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Don't reverse values in event filters #15584

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Mar 5, 2025

#15513 (comment) noticed a regression I introduced, reversing exceptions in the event, because I fumbled a reverse() call into the wrong location.

Should be fixed asap.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.13 KB -0.01% -2 B 🔽
@sentry/browser - with treeshaking flags 22.92 KB -0.02% -3 B 🔽
@sentry/browser (incl. Tracing) 36.2 KB -0.01% -3 B 🔽
@sentry/browser (incl. Tracing, Replay) 73.38 KB -0.01% -4 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.79 KB -0.01% -3 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 77.99 KB -0.01% -4 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.91 KB -0.01% -6 B 🔽
@sentry/browser (incl. Feedback) 39.66 KB -0.01% -4 B 🔽
@sentry/browser (incl. sendFeedback) 27.76 KB -0.02% -3 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.54 KB -0.02% -4 B 🔽
@sentry/react 24.95 KB -0.01% -2 B 🔽
@sentry/react (incl. Tracing) 38.08 KB -0.01% -2 B 🔽
@sentry/vue 27.38 KB -0.02% -3 B 🔽
@sentry/vue (incl. Tracing) 37.89 KB -0.01% -3 B 🔽
@sentry/svelte 23.17 KB -0.02% -3 B 🔽
CDN Bundle 24.34 KB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing) 36.24 KB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing, Replay) 71.25 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.41 KB -0.01% -1 B 🔽
CDN Bundle - uncompressed 71.12 KB -0.01% -3 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 107.51 KB -0.01% -3 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.78 KB -0.01% -3 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.31 KB -0.01% -3 B 🔽
@sentry/nextjs (client) 39.25 KB -0.01% -2 B 🔽
@sentry/sveltekit (client) 36.61 KB -0.01% -3 B 🔽
@sentry/node 142.14 KB -0.01% -4 B 🔽
@sentry/node - without tracing 95.57 KB -0.01% -4 B 🔽
@sentry/aws-serverless 119.92 KB -0.01% -3 B 🔽

View base workflow run

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we test this?

@lforst
Copy link
Member Author

lforst commented Mar 5, 2025

Could we test this?

It's such a dumb mistake a test would feel out of place and also didn't wanna waste time on coming up with a test that doesn't feel out of place.

@lforst lforst merged commit 03e61fe into develop Mar 5, 2025
150 checks passed
@lforst lforst deleted the lforst-fix-inversion branch March 5, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants