Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nestjs): Copy metadata in custom decorators #15598

Merged
merged 3 commits into from
Mar 5, 2025
Merged

fix(nestjs): Copy metadata in custom decorators #15598

merged 3 commits into from
Mar 5, 2025

Conversation

chargome
Copy link
Member

@chargome chargome commented Mar 5, 2025

  • adds functionality for copying metadata in our custom decorators
  • applies this to all our decorators, not just SentryTraced
  • unit tests

closes #14384

@chargome chargome self-assigned this Mar 5, 2025
andreiborza
andreiborza reviewed Mar 5, 2025
View reviewed changes
andreiborza
andreiborza approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice unit tests!

@chargome chargome merged commit 9db024d into develop Mar 5, 2025
150 checks passed
@chargome chargome deleted the cg/nest-decorators-reflect branch March 5, 2025 16:32
@github-actions github-actions bot mentioned this pull request Mar 6, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreiborza andreiborza andreiborza approved these changes

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@sentry/nestjs SentryTraced decorator does not retain metadata
2 participants
@chargome @andreiborza