ref(node): Move stack parser to utils so it can be used from Electron #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
changed the title
AbhiPrasad
reviewed
Jun 21, 2022
| } | ||
|
|
||
| /** Node.js stack line parser */ | ||
| export function nodeStackLineParser(getModule?: GetModuleFn): StackLineParser { |
There was a problem hiding this comment.
Can we leave a comment why we are exporting this from utils instead of the node package?
AbhiPrasad
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the node stack parser to utils so it can be used from the Electron SDK in the renderer without upsetting bundlers.
It already has it's node-specific functionality (getting the module name) refactored out into a separately supplied function. The stack parser remains exported from
@sentry/nodeso the public api does not change.