Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for k8s 1.25 #218

Merged
merged 10 commits into from
Feb 16, 2024
Merged

Prepare for k8s 1.25 #218

merged 10 commits into from
Feb 16, 2024

Conversation

marians
Copy link
Member

@marians marians commented Feb 16, 2024

Towards https://github.com/giantswarm/giantswarm/issues/29470

What does this PR do?

Prepares the app to be deployed to gazelle / operations which is K8s 1.25 with PSS enforced.

In detail:

  • Add security spec for PSS to deployments
  • Add a switch to only render PSP resources if .Values.global.podSecurityStandards.enforced is not true
  • Set namespace based on helm .Release.Namespace
  • Change a registry to gsoci
  • Remove an image pull policy (Always)

@marians marians self-assigned this Feb 16, 2024
@marians
Copy link
Member Author

marians commented Feb 16, 2024

Ran into this problem logged by the staticjscms pod:

/app/netlify-cms-github-oauth-provider/login_script.js:5
  throw new Error('process.env.ORIGIN MUST be comma separated list

The deployment had the ORIGINS env variable defined, but not ORIGIN, so I added it.

@marians
Copy link
Member Author

marians commented Feb 16, 2024

https://github.com/vencax/netlify-cms-github-oauth-provider/blob/master/login_script.js#L5

Turns out the error message is mistyped and the env variable must be ORIGINS.

@marians marians marked this pull request as ready for review February 16, 2024 15:16
@marians marians requested a review from a team as a code owner February 16, 2024 15:16
@marians marians requested a review from mproffitt February 16, 2024 15:16
Copy link

@mproffitt mproffitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marians marians merged commit 59ab202 into main Feb 16, 2024
6 of 7 checks passed
@marians marians deleted the prepare-for-k8s-1.25 branch February 16, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants