handbook: PDBs for all pods, require spread #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Replace preferredDuringSchedulingIgnoredDuringExecution with requiredDuringSchedulingIgnoredDuringExecution for podAntiAffinity to force spreading out app replicas on different nodes (HA) or not schedule them (stay in Pending). Add PDBs for all deployments to allow deleting and re-scheduling all but one replica (HA). Add RollingUpdate strategy. Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves the high availability and deployment strategy of the handbook and staticjscms-hugo-standalone deployments by:
Making pod anti-affinity required instead of preferred:
preferredDuringSchedulingIgnoredDuringExecutiontorequiredDuringSchedulingIgnoredDuringExecutionAdding PodDisruptionBudgets (PDBs) for all deployments:
minAvailable: 1to ensure at least one replica is always availableunhealthyPodEvictionPolicy: AlwaysAllowfor both PDBsAdding explicit RollingUpdate strategy:
maxSurge: 1andmaxUnavailable: 1Link to Devin run: https://app.devin.ai/sessions/9e6ed5a722aa40b1b3ca0844542981ca