Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Genero Business Development Language #5030

Merged
merged 9 commits into from
Mar 24, 2022
Merged

Add Support for Genero Business Development Language #5030

merged 9 commits into from
Mar 24, 2022

Conversation

alienriver49
Copy link
Contributor

Add support for Genero and Genero Forms. The grammars are different for these two "languages" which is why they have been separated out. Genero Forms is a markup for Genero which allows the rendering of Genero programs in Windows, Android, iOS, or the Web. There was no need to add heuristics as there were no languages using either the 4gl or per extension.

Description

Adding support for the Genero Business Development Language from FourJs. This language is the evolution of the language Informix 4GL. There is still a lot of Informix 4GL code out there and Genero 4GL code which is being maintained so it would be useful to have language detection and syntax highlighting in GitHub.

Checklist:

@lildude lildude requested review from pchaigno and Alhadis October 1, 2020 09:58
@lildude
Copy link
Member

lildude commented Nov 4, 2020

Unfortunately, popularity on GitHub for both extensions is far from meeting our requirements of:

We try only to add languages once they have some usage on GitHub. In most cases we prefer that each new file extension be in use in hundreds of repositories before supporting them in Linguist.

... where hundreds is considered over 200 unique user/repo combos, for inclusion in the immediate future. .4gl comes in at only being spread across 22 unique user/repos and .per across 130, but quite a few of those don't look like the samples in this PR so probably not the same language and thus likely to be less popular.

@Chavi-Ansar

This comment has been minimized.

@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Dec 25, 2020
@lildude lildude requested a review from a team as a code owner February 11, 2021 10:00
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you address the conflicts and replace the hello-world.4gl sample.

Once this is good to go, I'll approve this based on the temporary requirements detailed in #5756

@@ -0,0 +1,3 @@
main
display "Hello, World!"
end main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace this with a real-world sample.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just catching this now, I can resolve the conflicts and get a real world example added.

@alienriver49
Copy link
Contributor Author

@lildude This has had conflicts resolved and has been updated with a better example. Let me know if there are other pieces which need to be addressed.

@alienriver49 alienriver49 requested a review from lildude March 7, 2022 16:01
@lildude lildude merged commit adc5319 into github-linguist:master Mar 24, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants